Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
oschwald
force-pushed
the
greg/billing-phone-verification-inputs
branch
from
October 12, 2026 14:57
6da1d90 to
996a418
Compare
oschwald
changed the title
oschwald
force-pushed
the
greg/billing-phone-verification-inputs
branch
from
October 12, 2026 15:01
996a418 to
3ccabbc
Compare
Enum toString methods and email address cleaning called toLowerCase with the default locale. In locales such as tr-TR and az-AZ, "I" becomes a dotless "ı". Enum values then serialized as, for example, "account_creatıon", and the web service rejected them. Email hashing also produced a different MD5 for addresses that contain "I". Use Locale.ROOT for these conversions. Add a test that runs them under tr-TR. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add phoneVerificationMethod, phoneWasVerificationSuccessful, and phoneVerificationTime to the request. Both /billing and /shipping accept them. They describe the most recent verification of the phone number for the address. The inputs live in AbstractLocation, which Billing and Shipping share. The PhoneVerificationMethod enum serializes with Locale.ROOT so that locales such as tr-TR do not change the value. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oschwald
force-pushed
the
greg/billing-phone-verification-inputs
branch
from
October 12, 2026 16:21
3ccabbc to
cd97535
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds three optional inputs to the
BillingandShippingrequest objects:phoneVerificationMethod(DELIVERED_CODE,NETWORK,OTHER),phoneWasVerificationSuccessful, andphoneVerificationTime(ZonedDateTime). They sendphone_verification_method,phone_was_verification_successful, andphone_verification_timeunder/billingand/shipping. They describe the most recent verification of the phone number for that address.The inputs live in
AbstractLocation, whichBillingandShippingshare. ThePhoneVerificationMethodenum serializes withLocale.ROOT, so locales such as tr-TR do not change the values. Tests cover both objects, including omission of unset inputs.LocaleTestchecks the new enum under tr-TR.The branch has two commits:
Locale.ROOTfor case conversions. Under tr and az default locales, existing enum values serialized with a dotlessıand the web service rejected them. The commit fixes every enumtoStringand the email address lowercasing insrc/main, adds a tr-TR test, and updates the enum pattern inCLAUDE.md.🤖 Generated with Claude Code